Skip to content

#90 This makes the function tail recursive. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rupertlssmith
Copy link

This fixes issue #90.

I have tested it on the example given in that issue.

@jerith666
Copy link

This fix and #95 seem to be addressing the same bug.

lydell added a commit to lydell/browser that referenced this pull request Jul 13, 2025
Large collections, like lists with thousands of items, either cause the
debugger and the whole application to be very slow, or crash with a
stack overflow.

Closes elm/compiler#2133
Closes elm#90
Closes elm#104
Closes elm#132

Closes elm#120. That’s a previous PR
that touched on this problem. That PR makes the experience go from
crashing to awfully slow.

This PR is fast even with big collections, by expanding just the first
100 items. There’s a “view more” button to show the next 100. I went
with the simplest possible UX around that, since it’s unclear if anyone
actually tries to click to item number 9000 – at that point, search is
better. And then you could just as well do the search with Elm code and
`Debug.log` rather than using some obscure search syntax in the
debugger. I think looking at the model in the debugger is more for
learning the overall structure of an app, than to look at every single
item of long lists, sets or dicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants